Fix timeout bug in Genesis “Time limited leashing attack” test #1350
+129
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
approved these changes
Dec 19, 2024
ouroboros-consensus-diffusion/test/consensus-test/Test/Consensus/Genesis/Setup/GenChains.hs
Outdated
Show resolved
Hide resolved
- Always disable `mustReplyTimeout`; explain why - Always disable `idleTimeout`; explain why - Keep the others by default in all the tests This should fix the bug discussed in #1179
Niols
force-pushed
the
blockfetch/milestone-1-with-fix
branch
from
9c8a5d7 to
4e56180
Compare
nfrisby
reviewed
Dec 19, 2024
ouroboros-consensus-diffusion/test/consensus-test/Test/Consensus/Genesis/Setup/GenChains.hs
Show resolved
Hide resolved
nfrisby
approved these changes
Dec 19, 2024
Co-authored-by: Nicolas Frisby <nick.frisby@iohk.io>
|
Ran 2M tests, all green; previously, this would have had a very high probability to trigger the bug, so I have very strong confidence that this was the right fix. Will merge this. |
Niols
requested review from
amesgen,
fraser-iohk,
dnadales and
geo2a
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1179 for context.
Note 1: I am currently running extensive tests to check that this fix looks good indeed. I wouldn't want to reintroduce an other extremely rare bug! I will mark this PR as ready once I am happy with the result, hopefully tomorrow 🤞
Note 2: There is a big more than just the fix, because I thought that some of my debugging work could be kept for posterity. Feel free to tell me to discard some bits and pieces, the commits are very independent for a reason.