Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CDDL specs by using any #4595

Closed
10 tasks done
coot opened this issue Jun 13, 2023 · 1 comment · Fixed by #4638
Closed
10 tasks done

Improve CDDL specs by using any #4595

coot opened this issue Jun 13, 2023 · 1 comment · Fixed by #4638
Assignees
Labels
block-fetch Issues related to block fetch component. chain-sync local-state-query Issues / PRs related to local-state-query protocol local-tx-monitor LocalTxMonitor protocol local-tx-submission Issues / PRs related to local-tx-submission mini-protocol tx-submission Issues related to tx-submission protocol

Comments

@coot
Copy link
Contributor

coot commented Jun 13, 2023

CDDL has the notion of any which can be used to indicate that something is not specified. We provided this for Tx and TxId in tx-submission mini-protocol in #4580. It would be nide to extend this approach to other mini-protocols.

@coot coot added chain-sync tx-submission Issues related to tx-submission protocol local-state-query Issues / PRs related to local-state-query protocol local-tx-monitor LocalTxMonitor protocol block-fetch Issues related to block fetch component. local-tx-submission Issues / PRs related to local-tx-submission mini-protocol labels Jun 13, 2023
@bolt12 bolt12 self-assigned this Jul 19, 2023
@bolt12
Copy link
Contributor

bolt12 commented Jul 19, 2023

I took a look into this. And the rest of the protocols use ouroboros-network-mock and ouroboros-network-api mock types for Point, Block, etc.. types. I am not sure we want to stop using these since they belong to the testing ecosystem and mock the real thing.

For example SlotNo could be Any but we are using a type that comes from cardano-slotting and changing it to Any would be a lot of effort

@coot coot assigned coot and unassigned bolt12 Aug 8, 2023
@coot coot linked a pull request Aug 8, 2023 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block-fetch Issues related to block fetch component. chain-sync local-state-query Issues / PRs related to local-state-query protocol local-tx-monitor LocalTxMonitor protocol local-tx-submission Issues / PRs related to local-tx-submission mini-protocol tx-submission Issues related to tx-submission protocol
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants