Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use any in cddl specs / tests. #4638

Merged
merged 5 commits into from
Aug 18, 2023
Merged

Use any in cddl specs / tests. #4638

merged 5 commits into from
Aug 18, 2023

Conversation

coot
Copy link
Contributor

@coot coot commented Aug 8, 2023 •
edited
Loading

  • TxSubmission: removed the Hello transformer
  • cddl: updated documentation
  • cddl: removed unused definitions
  • cddl: use Any in the local-state-query mini-protocol
  • cddl: use Any in the chain-sync mini-protocol

TODO:

  • cddl: use Any in the local-tx-monitor mini-protocol - not needed, we instantiate SlotNo to Word64 in CDDL which is the right type.

@coot coot mentioned this pull request Aug 8, 2023
Closed
10 tasks
@coot coot linked an issue Aug 8, 2023 that may be closed by this pull request
Improve CDDL specs by using any #4595
Closed
10 tasks
@coot coot changed the title coot/cddl chain sync Use any in cddl specs / tests. Aug 8, 2023
@coot coot marked this pull request as ready for review August 9, 2023 08:32
@coot coot force-pushed the coot/cddl-chain-sync branch 2 times, most recently from 6eda3fb to 4770d41 Compare August 9, 2023 13:48
bolt12
bolt12 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@bolt12 bolt12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coot coot enabled auto-merge August 16, 2023 12:02
@coot
TxSubmission: removed the Hello transformer
9aed02b 
We used it to transform TxSubmission v1 into v2, but this is no longer
the case.
@coot coot added this pull request to the merge queue Aug 18, 2023
Merged via the queue into master with commit b2105a0 Aug 18, 2023
8 checks passed
@coot coot deleted the coot/cddl-chain-sync branch August 18, 2023 10:22
coot added a commit that referenced this pull request Jan 29, 2024
@coot
ouroboros-network-protocols: removed not used modules
d38305f 
Hello wrapper was removed in PR #4638.
coot added a commit that referenced this pull request Jan 29, 2024
@coot
ouroboros-network-protocols: removed not used modules
7b08e41 
Hello wrapper was removed in PR #4638.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolt12 bolt12 bolt12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve CDDL specs by using any
2 participants
@coot @bolt12