Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PeerSharing negotiated even when it is disabled. #4642

Closed
karknu opened this issue Aug 14, 2023 · 0 comments · Fixed by #4644
Closed

PeerSharing negotiated even when it is disabled. #4642

karknu opened this issue Aug 14, 2023 · 0 comments · Fixed by #4644
Assignees
@bolt12
Labels
bug Something isn't working peer-sharing Issues / PRs related to peer sharing

Comments

@karknu
Copy link
Contributor

karknu commented Aug 14, 2023 •
edited
Loading

When a client signals that it supports PeerSharing, either public or private the server will simply echo the clients which. It won't take its own configuration into account.

{"app":[],"at":"2023-08-14T10:32:04.47Z","data":{"connectionHandler":{"agreedOptions":{"diffusionMode":"InitiatorAndResponderDiffusionMode","networkMagic":764824073,"peerSharing":"PeerSharingPublic","query":false},"kind":"HandshakeSuccess","versionNumber":11},"connectionId":{"localAddress":{"address":"1.1.1.1","port":"3001"},"remoteAddress":{"address":"1.2.2.12","port":"3001"}},"kind":"ConnectionHandler"},"env":"8.1.1:6f79e","host":"testnet-","loc":null,"msg":"","ns":["cardano.node.ConnectionManager"],"pid":"2497934","sev":"Info","thread":"858"}
@bolt12 bolt12 self-assigned this Aug 17, 2023
@bolt12 bolt12 added bug Something isn't working networking peer-sharing Issues / PRs related to peer sharing labels Aug 17, 2023
bolt12 added a commit that referenced this issue Aug 17, 2023
@bolt12
Fix Peer Sharing issue #4642
f9e9ab7 
- Adds `LocalPeerSharing` and `RemotePeerSharing` newtypes
- Add `localPeerSharing` and `remotePeerSharing` fields to
  `NodeToNodeVersionData` and `DataFlowProtocolData`
- Renamed `cmGetPeerSharing` to `cmGetRemotePeerSharing`
- Used `LocalPeerSharing` and `RemotePeerSharing` whenever it is useful
- Add test to check that the bug is fixed
@bolt12 bolt12 mentioned this issue Aug 17, 2023
Merged
bolt12 added a commit that referenced this issue Aug 17, 2023
@bolt12
Fix Peer Sharing issue #4642
1c81439 
- Adds `LocalPeerSharing` and `RemotePeerSharing` newtypes
- Add `localPeerSharing` and `remotePeerSharing` fields to
  `NodeToNodeVersionData` and `DataFlowProtocolData`
- Renamed `cmGetPeerSharing` to `cmGetRemotePeerSharing`
- Used `LocalPeerSharing` and `RemotePeerSharing` whenever it is useful
- Add test to check that the bug is fixed
- Add new `NodeToNodeV_13`
- Renamed spec files and added V13 CDDL handshake and
  `NodeToNodeVersionData` specs
bolt12 added a commit that referenced this issue Sep 4, 2023
@bolt12
Fix Peer Sharing issue #4642
8ed5dbc 
- Adds `LocalPeerSharing` and `RemotePeerSharing` newtypes
- Add `localPeerSharing` and `remotePeerSharing` fields to
  `NodeToNodeVersionData` and `DataFlowProtocolData`
- Renamed `cmGetPeerSharing` to `cmGetRemotePeerSharing`
- Used `LocalPeerSharing` and `RemotePeerSharing` whenever it is useful
- Add test to check that the bug is fixed
- Add new `NodeToNodeV_13`
- Renamed spec files and added V13 CDDL handshake and
  `NodeToNodeVersionData` specs
bolt12 added a commit that referenced this issue Sep 4, 2023
@bolt12
Fix Peer Sharing issue #4642
12d0e25 
- Adds `LocalPeerSharing` and `RemotePeerSharing` newtypes
- Add `localPeerSharing` and `remotePeerSharing` fields to
  `NodeToNodeVersionData` and `DataFlowProtocolData`
- Renamed `cmGetPeerSharing` to `cmGetRemotePeerSharing`
- Used `LocalPeerSharing` and `RemotePeerSharing` whenever it is useful
- Add test to check that the bug is fixed
- Add new `NodeToNodeV_13`
- Renamed spec files and added V13 CDDL handshake and
  `NodeToNodeVersionData` specs
bolt12 added a commit that referenced this issue Sep 18, 2023
@bolt12
Fix Peer Sharing issue #4642
50cd5de 
- Adds `LocalPeerSharing` and `RemotePeerSharing` newtypes
- Add `localPeerSharing` and `remotePeerSharing` fields to
  `NodeToNodeVersionData` and `DataFlowProtocolData`
- Renamed `cmGetPeerSharing` to `cmGetRemotePeerSharing`
- Used `LocalPeerSharing` and `RemotePeerSharing` whenever it is useful
- Add test to check that the bug is fixed
- Add new `NodeToNodeV_13`
- Renamed spec files and added V13 CDDL handshake and
  `NodeToNodeVersionData` specs
bolt12 added a commit that referenced this issue Sep 18, 2023
@bolt12
Fix Peer Sharing issue #4642
7003b2a 
- Remove `PeerSharingPrivate` option and renamed others to
  `PeerSharingDisabled` and `PeerSharingEnabled`
- Add test to check that the bug is fixed
- Add new `NodeToNodeV_13`
- Renamed spec files and added V13 CDDL handshake and
  `NodeToNodeVersionData` specs
bolt12 added a commit that referenced this issue Sep 18, 2023
@bolt12
Fix Peer Sharing issue #4642
da8df7f 
- Remove `PeerSharingPrivate` option and renamed others to
  `PeerSharingDisabled` and `PeerSharingEnabled`
- Add test to check that the bug is fixed
- Add new `NodeToNodeV_13`
- Renamed spec files and added V13 CDDL handshake and
  `NodeToNodeVersionData` specs
bolt12 added a commit that referenced this issue Sep 26, 2023
@bolt12
Fix Peer Sharing issue #4642
9f5163a 
- Remove `PeerSharingPrivate` option and renamed others to
  `PeerSharingDisabled` and `PeerSharingEnabled`
- Add test to check that the bug is fixed
- Add new `NodeToNodeV_13`
- Renamed spec files and added V13 CDDL handshake and
  `NodeToNodeVersionData` specs
bolt12 added a commit that referenced this issue Oct 2, 2023
@bolt12
Fix Peer Sharing issue #4642
d787f09 
- Remove `PeerSharingPrivate` option and renamed others to
  `PeerSharingDisabled` and `PeerSharingEnabled`
- Add test to check that the bug is fixed
- Add new `NodeToNodeV_13`
- Renamed spec files and added V13 CDDL handshake and
  `NodeToNodeVersionData` specs
bolt12 added a commit that referenced this issue Oct 11, 2023
@bolt12
Fix Peer Sharing issue #4642
588e649 
- Remove `PeerSharingPrivate` option and renamed others to
  `PeerSharingDisabled` and `PeerSharingEnabled`
- Add test to check that the bug is fixed
- Add new `NodeToNodeV_13`
- Renamed spec files and added V13 CDDL handshake and
  `NodeToNodeVersionData` specs
bolt12 added a commit that referenced this issue Oct 23, 2023
@bolt12
Fix Peer Sharing issue #4642
3ba43b4 
- Remove `PeerSharingPrivate` option and renamed others to
  `PeerSharingDisabled` and `PeerSharingEnabled`
- Add test to check that the bug is fixed
- Add new `NodeToNodeV_13`
- Renamed spec files and added V13 CDDL handshake and
  `NodeToNodeVersionData` specs
bolt12 added a commit that referenced this issue Oct 27, 2023
@bolt12
Fix Peer Sharing issue #4642
8ebbb6b 
- Remove `PeerSharingPrivate` option and renamed others to
  `PeerSharingDisabled` and `PeerSharingEnabled`
- Add test to check that the bug is fixed
- Add new `NodeToNodeV_13`
- Renamed spec files and added V13 CDDL handshake and
  `NodeToNodeVersionData` specs
bolt12 added a commit that referenced this issue Oct 27, 2023
@bolt12
Fix Peer Sharing issue #4642
7493b5d 
- Remove `PeerSharingPrivate` option and renamed others to
  `PeerSharingDisabled` and `PeerSharingEnabled`
- Add test to check that the bug is fixed
- Add new `NodeToNodeV_13`
- Renamed spec files and added V13 CDDL handshake and
  `NodeToNodeVersionData` specs
bolt12 added a commit that referenced this issue Oct 27, 2023
@bolt12
Fix Peer Sharing issue #4642
516352c 
- Remove `PeerSharingPrivate` option and renamed others to
  `PeerSharingDisabled` and `PeerSharingEnabled`
- Add test to check that the bug is fixed
- Add new `NodeToNodeV_13`
- Renamed spec files and added V13 CDDL handshake and
  `NodeToNodeVersionData` specs
bolt12 added a commit that referenced this issue Oct 30, 2023
@bolt12
Fix Peer Sharing issue #4642
314574f 
- Remove `PeerSharingPrivate` option and renamed others to
  `PeerSharingDisabled` and `PeerSharingEnabled`
- Add test to check that the bug is fixed
- Add new `NodeToNodeV_13`
- Renamed spec files and added V13 CDDL handshake and
  `NodeToNodeVersionData` specs
github-merge-queue bot pushed a commit that referenced this issue Oct 31, 2023
@bolt12
Merge pull request #4644 from input-output-hk/bolt12/fix-peerSharing-…
6296e40 
…handshake

Fix Peer Sharing issue #4642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bolt12 bolt12

Labels
bug Something isn't working peer-sharing Issues / PRs related to peer sharing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Peer Sharing issue #4642 IntersectMBO/ouroboros-network
2 participants
@karknu @bolt12