dns: limit concurrency when resolving dns names #4596
Merged
+100
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Affects: #4585. |
2 tasks
coot
force-pushed
the
coot/dns-limit-concurrency
branch
from
061e0a2 to
7034e93
Compare
|
LGTM. |
bolt12
requested changes
Jun 15, 2023
ouroboros-network/src/Ouroboros/Network/PeerSelection/RootPeersDNS.hs
Outdated
Show resolved
Hide resolved
coot
force-pushed
the
coot/dns-limit-concurrency
branch
2 times, most recently
from
1dde6b6 to
f3c3064
Compare
bolt12
approved these changes
Jun 23, 2023
coot
force-pushed
the
coot/dns-limit-concurrency
branch
from
f3c3064 to
cf29967
Compare
* local root peers * public root peers * ledger peers
coot
force-pushed
the
coot/dns-limit-concurrency
branch
from
cf29967 to
ca544a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use two semaphores. One to limit concurrency of dns name resolution of local root peers to at most
2; and another one to limit concurrency for public & ledger peers to at most8.