Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #4624

Closed
wants to merge 4 commits into from
Closed

Fix typos #4624

wants to merge 4 commits into from

Conversation

eyeinsky
Copy link
Contributor

  • Of cause => Of course
  • EOL spaces removed

Description

description of the pull request, if it fixes a particular issue it should link the PR to a particular issue, see ref

Checklist

  • Branch
    • [-] Updated changelog files.
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • [-] New tests are added if needed and existing tests are updated
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

bolt12
bolt12 requested changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@bolt12 bolt12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Go ahead and fixup the last commit! LGTMT 😄

@eyeinsky
Copy link
Contributor Author

@bolt12 How do you mean? :p Like squash it into a single commit?

@bolt12
Copy link
Contributor

bolt12 commented Jul 18, 2023

Yes, I noticed it is a fixup one and I am not sure it will get fixed up on merge

@eyeinsky
Copy link
Contributor Author

Got it, and done!

@bolt12
Copy link
Contributor

bolt12 commented Jul 18, 2023

Thank you!

@eyeinsky
Copy link
Contributor Author

(Found one more and force-pushed it: arguemts => arguments)

@eyeinsky
Fix typos
aeb86e0 
- Of cause => Of course
- EOL spaces removed
- arguemnts => arguments
- communicate communicate => communicate
@eyeinsky
Copy link
Contributor Author

One more: communicate communicate => communicate

@bolt12
Copy link
Contributor

bolt12 commented Jul 19, 2023

Alright! Keep it up 😄 Thank you!

coot
coot approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@coot
Copy link
Contributor

coot commented Aug 16, 2023

@eyeinsky could you squash the commits and rebase them on top of master?

@coot coot mentioned this pull request Aug 25, 2023
Merged
9 tasks
@coot
Copy link
Contributor

coot commented Aug 25, 2023

Closing it in favour of #4659, thank you @eyeinsky.

@coot coot closed this Aug 25, 2023
@eyeinsky
Copy link
Contributor Author

@coot Sorry, somehow missed this, thanks for making the other PR! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot approved these changes

@bolt12 bolt12 bolt12 approved these changes

@njd42 njd42 Awaiting requested review from njd42

@peterwthompson peterwthompson Awaiting requested review from peterwthompson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eyeinsky @bolt12 @coot