Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated release process #4705

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Updated release process #4705

merged 1 commit into from
Oct 27, 2023

Conversation

coot
Copy link
Contributor

@coot coot commented Oct 26, 2023

Description

Updated release process in CONTRIBUTING.md.
Fixed ./script/build-with-chap.sh.

Checklist

  • Branch
    • Updated changelog files.
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • New tests are added if needed and existing tests are updated
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

Fixed `./script/build-with-chap.sh`.
@coot coot requested a review from bolt12 as a code owner October 26, 2023 18:38
@coot coot self-assigned this Oct 26, 2023
@coot coot added this pull request to the merge queue Oct 27, 2023
Merged via the queue into master with commit dda3400 Oct 27, 2023
11 checks passed
@coot coot deleted the coot/release-process branch October 27, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants