Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBOR mini-protocols codecs benchmarks #4798

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Conversation

bolt12
Copy link
Contributor

@bolt12 bolt12 commented Feb 6, 2024

Description

Added mini protocols codec benchmarks. The idea is then to have CI running these benchmarks on different GHC versions and machines and compare them to a baseline result, failing if a regression is found.

Closes #4709

@coot
Copy link
Contributor

coot commented Feb 12, 2024

The CI broke on ghc9.8:

Get-Content: D:\a\_temp\32e79902-26c2-46a1-ae93-05d60f57912f.ps1:3
Line |
   3 |  cat dist-newstyle/cache/plan.json | jq -L .github/workflows/jq-instal …
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Cannot find path 'D:\a\ouroboros-network\ouroboros-network\dist-newstyle\cache\plan.json' because it does not
     | exist.
Error: Process completed with exit code 1.

It's not something I've seen before, have you?

@bolt12
Copy link
Contributor Author

bolt12 commented Feb 12, 2024

I haven't seen it happen before, no. I don't think this PR makes any related changes

Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bolt12. A few minor comments.

ouroboros-network-api/CHANGELOG.md Outdated Show resolved Hide resolved
ouroboros-network-framework/CHANGELOG.md Outdated Show resolved Hide resolved
ouroboros-network-protocols/CHANGELOG.md Outdated Show resolved Hide resolved
ouroboros-network-protocols/bench-cddl/Main.hs Outdated Show resolved Hide resolved
ouroboros-network-protocols/bench-cddl/Main.hs Outdated Show resolved Hide resolved
ouroboros-network-protocols/bench-cddl/Main.hs Outdated Show resolved Hide resolved
ouroboros-network-protocols/bench-cddl/Main.hs Outdated Show resolved Hide resolved
@bolt12 bolt12 requested a review from a team as a code owner March 7, 2024 11:05
@bolt12 bolt12 requested a review from coot March 7, 2024 11:35
@bolt12 bolt12 enabled auto-merge March 7, 2024 12:11
@bolt12 bolt12 self-assigned this Mar 7, 2024
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bolt12 bolt12 added this pull request to the merge queue Mar 12, 2024
Merged via the queue into master with commit 72c8f5d Mar 12, 2024
13 of 14 checks passed
@bolt12 bolt12 deleted the bolt12/cbor-benchmarks-2 branch March 12, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Write microbenchmarks for mini-protocol CBOR codecs
2 participants