Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable mean reward for new peers #4800

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Disable mean reward for new peers #4800

merged 1 commit into from
Feb 8, 2024
+5 −2

Conversation

karknu
Copy link
Contributor

@karknu karknu commented Feb 8, 2024 •
edited
Loading

Description

Newly added peers where given a boost up to the mean score. That gives too much of a bonus for them which means that they can out compete useful, but not top performing peers.

The code is commented out and the reward set to zero for now. In the future we can decide what, if any, reward should be given to new peers.

Checklist

  • Branch
    • Updated changelog files.
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • New tests are added if needed and existing tests are updated
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@karknu
Disable mean reward for new peers
2162ea7 
Newly added peers where given a boost up to the mean score.
That gives too much of a bonus for them which means that they can out
compete usefull, but not top performing peers.

The code is commented out and the reward set to zero for now. In the
future we can decide what, if any, reward should be given to new peers.
@karknu karknu marked this pull request as ready for review February 8, 2024 07:37
@karknu karknu requested a review from coot as a code owner February 8, 2024 07:37
coot
coot approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @karknu

@karknu karknu added this pull request to the merge queue Feb 8, 2024
Merged via the queue into master with commit 436d902 Feb 8, 2024
10 checks passed
@karknu karknu deleted the karknu/disable_mean branch February 8, 2024 09:12
@coot coot added the churn Issues / PRs related to churn label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot approved these changes

Assignees

@karknu karknu

Labels
churn Issues / PRs related to churn
Projects
Ouroboros Network
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karknu @coot