TxSubmission - add initial delay before requesting transactions #4930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crocodile-dentist
force-pushed
the
mwojtowicz/tx-submission-initial-delay
branch
from
4aeab2e
to
65be023
Compare
crocodile-dentist
added
the
tx-submission
crocodile-dentist
force-pushed
the
mwojtowicz/tx-submission-initial-delay
branch
from
65be023
to
6575f23
Compare
coot
requested changes
Aug 13, 2024
ouroboros-network/src/Ouroboros/Network/TxSubmission/Inbound.hs
Outdated
Show resolved
Hide resolved
crocodile-dentist
force-pushed
the
mwojtowicz/tx-submission-initial-delay
branch
3 times, most recently
from
0223712
to
59afec6
Compare
This change delays initial request for transactions from the client, whom may disconnect relatively quickly for reasons described in IntersectMBO/ouroboros-network issue #4927.
crocodile-dentist
force-pushed
the
mwojtowicz/tx-submission-initial-delay
branch
from
59afec6
to
53e133d
Compare
6 tasks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We delay initial request for transactions from a client to conserve network resources in case he disconnects relatively quickly for reasons in the referenced issue.
resolves #4927
Checklist
Quality
Maintenance
ouroboros-networkproject.