Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connection-manager: renamed methods #5000

Merged
merged 1 commit into from
Oct 29, 2024
Merged

connection-manager: renamed methods #5000

merged 1 commit into from
Oct 29, 2024

Conversation

coot
Copy link
Contributor

@coot coot commented Oct 25, 2024

Description

Renamed connection-manager methods as requested in #3464.

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@coot coot requested a review from a team as a code owner October 25, 2024 10:55
@coot coot added the connection-manager Issues / PRs related to connection-manager label Oct 25, 2024
@coot coot self-assigned this Oct 25, 2024
njd42
njd42 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@njd42 njd42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the name changes make a lot of sense

@coot coot added this pull request to the merge queue Oct 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 29, 2024
@coot coot added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 1a7ff3e Oct 29, 2024
12 of 13 checks passed
@coot coot deleted the coot/connection-manager branch October 29, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semanticphilosopher semanticphilosopher semanticphilosopher left review comments

@njd42 njd42 njd42 approved these changes

Assignees

@coot coot

Labels
connection-manager Issues / PRs related to connection-manager
Projects
Ouroboros Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coot @semanticphilosopher @njd42