Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT-1485: Investigate issue #4826 #5280

Closed
wants to merge 14 commits into from

Conversation

thealmarty
Copy link
Contributor

@thealmarty thealmarty commented May 1, 2023

For #4826.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Changelog fragments have been written (if appropriate)
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • (For external contributions) Corresponding issue exists and is linked in the description
    • Targeting master unless this is a cherry-pick backport
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@thealmarty thealmarty force-pushed the thealmarty/plt-1485-issue-4826 branch 2 times, most recently from 87d38fd to 640701e Compare May 1, 2023 17:17
@thealmarty thealmarty added Do not merge EXPERIMENT Experiments that we probably don't want to merge labels May 1, 2023
@thealmarty thealmarty force-pushed the thealmarty/plt-1485-issue-4826 branch 2 times, most recently from 7456587 to a719919 Compare May 2, 2023 16:16
@thealmarty thealmarty force-pushed the thealmarty/plt-1485-issue-4826 branch from a719919 to 3d707d0 Compare May 2, 2023 16:21
@thealmarty
Copy link
Contributor Author

thealmarty commented May 2, 2023

Summary:

  • Add NOINLINE pragma to the local function: Y, but unreasonable request, esp with INLINABLE pragma. Good work around for now.
  • Add strict language pragma: Y, but things may break and it's less controllable than NOINLINE.
  • Add -fmax-simplifier-iterations=0 or -fmax-simplifier-iterations=0 -fforce-recomp or -fmax-simplifier-iterations=0 -fforce-recomp -O0 ghc options: N
  • Turn off sm_pre_inline and force recompile: N
  • Turn off sm_cast_swizzle and force recompile: N
  • Turn off mkSimplPass or move it after the plugin pass makes the code not compile.

@thealmarty
Copy link
Contributor Author

Investigation done. Created ticket for next steps.

@thealmarty thealmarty closed this May 3, 2023
@thealmarty thealmarty mentioned this pull request May 3, 2023
11 tasks
@kwxm kwxm deleted the thealmarty/plt-1485-issue-4826 branch November 10, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do not merge EXPERIMENT Experiments that we probably don't want to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants