[Refactoring] Replace 'NOINLINE' with 'OPAQUE' #6507
Merged
+145
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectfully
added
Refactoring
No Changelog Required
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
/benchmark validation |
|
/benchmark nofib |
|
/benchmark lists |
|
/benchmark marlowe |
|
Click here to check the status of your benchmark. |
|
OPAQUE is strictly better than NOINLINE for the plugin, but I don't think that is the case for non-Plinth code. |
Sure, but usually when I write |
|
Comparing benchmark results of 'validation' on 'e94d73c65' (base) and '38b1487f8' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Interesting! |
|
Comparing benchmark results of 'nofib' on 'e94d73c65' (base) and '38b1487f8' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
It honestly looks like the benchmarking machine is broken. I'll test that separately. |
|
Comparing benchmark results of 'lists' on 'e94d73c65' (base) and '38b1487f8' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'marlowe' on 'e94d73c65' (base) and '38b1487f8' (PR) Results table
|
|
The benchmarking machine is broken at the moment, so we can't get accurate benchmarking results. I think it's unlikely that we need |
zliu41
approved these changes
Sep 21, 2024
effectfully
deleted the
effectfully/refactoring/replace-NOINLINE-with-OPAQUE
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces all occurrences of
NOINLINEwith the more reliableOPAQUE. However unlikeNOINLINEOPAQUEprevents specialization, so let's benchmark this to make sure there's no unexpected slowdown.Resolves #6269.