Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Disable 'prop_shrinkTermSound' #6695

Merged
merged 1 commit into from
Nov 20, 2024
Merged

[Test] Disable 'prop_shrinkTermSound' #6695

merged 1 commit into from
Nov 20, 2024

Conversation

effectfully
Copy link
Contributor

No description provided.

@effectfully effectfully requested a review from kwxm November 20, 2024 16:21
@effectfully effectfully added the No Changelog Required Add this to skip the Changelog Check label Nov 20, 2024
@effectfully effectfully force-pushed the effectfully/test/disable-shrinkTermSound branch from 1f5078c to 3a6cd71 Compare November 20, 2024 16:35
@effectfully effectfully force-pushed the effectfully/test/disable-shrinkTermSound branch from 3a6cd71 to 4d02140 Compare November 20, 2024 16:35
@kwxm
Copy link
Contributor

kwxm commented Nov 20, 2024 •
edited
Loading

Ironically this PR now appears to be failing on noTermShrinkLoops (but I now see that you've turned that off too).

I also got a very long run in stats_numShrink.

kwxm
kwxm approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@kwxm kwxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may still not be enough, but let's try it and see. We should maybe make a issue to find out why this started happening and try to fix it properly if possible.

@effectfully effectfully force-pushed the effectfully/test/disable-shrinkTermSound branch from 4d02140 to 73ffa2f Compare November 20, 2024 17:41
@effectfully
Copy link
Contributor Author

I also got a very long run in stats_numShrink.

Disabled it as well.

We should maybe make a issue to find out why this started happening and try to fix it properly if possible.

Added an entry to #6608.

@kwxm kwxm enabled auto-merge (squash) November 20, 2024 18:10
@effectfully effectfully self-assigned this Nov 20, 2024
@kwxm kwxm merged commit e42a2e7 into master Nov 20, 2024
8 checks passed
@kwxm kwxm deleted the effectfully/test/disable-shrinkTermSound branch November 20, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwxm kwxm kwxm approved these changes

Assignees

@effectfully effectfully

Labels
bug Generators No Changelog Required Add this to skip the Changelog Check Plutus IR Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@effectfully @kwxm