-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0138 array #6749
base: yura/cip-0138-builtin-array
Are you sure you want to change the base?
CIP-0138 array #6749
Conversation
1599c6d
to
074629d
Compare
074629d
to
e6dad3a
Compare
5f9e7e1
to
58f219c
Compare
58f219c
to
d48a07a
Compare
d48a07a
to
1f4f7cb
Compare
1f4f7cb
to
850bb4d
Compare
fe5c0a3
to
2ac9dba
Compare
850bb4d
to
19d137e
Compare
19d137e
to
a10f2fa
Compare
a10f2fa
to
c3b233f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't implement the builtin functions, right? It just defines them and the compiler recognizes them as builtins, but the evaluator doesn't yet know how to evaluate them. I assume that will be done in a separate commit/PR.
c3b233f
to
514b31a
Compare
@@ -97,6 +97,12 @@ data ParamName = | |||
| FstPair'memory'arguments | |||
| HeadList'cpu'arguments | |||
| HeadList'memory'arguments | |||
| LengthArray'cpu'arguments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New parameters must be appended, not inserted in the middle.
And these names don't seem accurate - e.g., ListToArray
is linear, so there needs to be an intercept and a slope. If they aren't accurate, then I'm not sure what the point is adding them at all. @kwxm What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also these need to be added to V1 and V2 as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New parameters must be appended, not inserted in the middle.
👍🏼 I wrote a golden test which will fail if this condition is violated
And these names don't seem accurate - e.g., ListToArray is linear, so there needs to be an intercept and a slope. If they aren't accurate, then I'm not sure what the point is adding them at all.
The point is to make build green. Some parameters have to be added, otherwise CI tests fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote a golden test which will fail if this condition is violated
How do we update the golden file when new parameters are added?
The point is to make build green. Some parameters have to be added, otherwise CI tests fail.
I'll let @kwxm check whether this is the right thing to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we update the golden file when new parameters are added?
cabal test plutus-ledger-api-test
fails if new parameter names were inserted in the middle, not appended.
cabal test plutus-ledger-api-test --test-options --accept
updates the golden file.
48a36dc
to
00e6771
Compare
ca42326
to
a0268bc
Compare
Closes ##6731