[IP-1012]: Revert change to invoice_logo() #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
nielsdrost7
changed the title
Computer-Ron
approved these changes
Apr 21, 2024
There was a problem hiding this comment.
I am a novice interacting with GitHub so apologize in advance if not following proper procedure and/or protocol. I have implemented this change on my 1.6.1 installation and can report this change indeed resolves the logo not showing on email invoices issue by using the correct path for finding the file on the server (base vs absolute).
|
Thanks @Computer-Ron for confirming you had a good result with the change, someone with access to the repository needs to make the review for it to automatically merge but maybe your input will prompt @nielsdrost7 to lend a hand, thanks! |
|
@jmclaren7 merged! @Computer-Ron thanks for the PR, man! Keep'em coming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invoice_logo() produces an invalid URL based on an absolute file system path, it seems this change was only intended for invoice_logo_pdf()
Related issue: #1012