Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown content not updating on change in IE11 #57

Closed
peterchappell opened this issue Mar 5, 2019 · 2 comments
Closed

Markdown content not updating on change in IE11 #57

peterchappell opened this issue Mar 5, 2019 · 2 comments

Comments

@peterchappell
Copy link
Contributor

peterchappell commented Mar 5, 2019

I noticed while testing in IE11 that the markdown content does not update when you make changes in the content editable area.

You can replicate the issue using the project's demo page in IE11:
http://ionicabizau.github.io/medium-editor-markdown/example/

I have fixed this issue locally by adding a subscribeToMeEditableInputEvent option:

        if (options.subscribeToMeEditableInputEvent) {
            this.base.subscribe('editableInput', handler);
        } else {
            options.events.forEach(function (c) {
                this.element.addEventListener(c, handler);
            }.bind(this));
        }

Very happy to submit a PR for this and follow any suggestions that you have for improvements.

@peterchappell
Copy link
Contributor Author

PR is #58

@IonicaBizau
Copy link
Owner

This is fixed I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants