-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the last period force remove if user unmarked the first day of the last period #196
Conversation
19f45dd
to
4de988a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 bugs:
- When the user marks only the future day, not the last one is removed, but all the cycles.
- When you switch to the editing of the calendar, the calendar switches in the first month of history, and not the last
@IraSoro I agree with the first bug. It was because I believed in the variable name About the second bug. I cannot reproduce what you described. As example, I generated 2 cycles Let's click on Let's click on Let's click on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is fine. Just add the ability to edit future days.
e1fb634
to
77d7c01
Compare
@imblowfish please check the last commit |
Everything is fine |
Closed #166
Closed #171
In this PR I added possibility to save empty array of cycles. Also I removed isMarkedFutureDays because now we using ion-datetime built-in limitation instead of custom checks
Also I added the new test #195