Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Download latest release button #243

Merged
merged 7 commits into from
Jul 9, 2024
Merged

Fixed Download latest release button #243

merged 7 commits into from
Jul 9, 2024

Conversation

imblowfish
Copy link
Collaborator

@imblowfish imblowfish commented Jul 6, 2024 •
edited
Loading

Closes #242

I tried all available options for window.open's target parameter, such as _system, _blank, _self, but nothing works
I tried to use @capacitor/browser instead of window.open, but it doesn't work. The browser is still opens page and nothing happens

Also I checked capacitor's github issues and didn't find anything useful to fix this behavior. so, instead I decided to replace our current download flow to the following flow, it's not as convenient as before, but at least it works:
image
image
image

For @ionic/browser using I upgraded ionic and capacitor to the latest versions
As you can see also I placed Dockerfile in the repository and changed BUILDING.md file

@imblowfish imblowfish added this to the v2.4.1 milestone Jul 6, 2024
@imblowfish imblowfish self-assigned this Jul 6, 2024
@imblowfish imblowfish requested a review from IraSoro July 6, 2024 23:26
IraSoro
IraSoro previously approved these changes Jul 9, 2024
View reviewed changes
BUILDING.md Outdated
```

And run:
You can also create a development version of native `peri` using the `Docker` image. To to this you should run the following command:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"To to this ..." - maybe "To do this ..."

@IraSoro IraSoro self-requested a review July 9, 2024 18:47
@IraSoro IraSoro merged commit 8c95d68 into master Jul 9, 2024
1 check passed
@IraSoro IraSoro deleted the 242-fix-download-latest-version-button branch July 9, 2024 18:54
IraSoro added a commit that referenced this pull request Jul 18, 2024
@IraSoro
Revert "Merge pull request #243 from IraSoro/242-fix-download-latest-…
5e381bf 
…version-button"

This reverts commit 8c95d68, reversing
changes made to 1187763.
@IraSoro IraSoro mentioned this pull request Jul 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IraSoro IraSoro IraSoro approved these changes

Assignees

@imblowfish imblowfish

Labels
None yet
Projects
peri
Status: Done
Milestone
v2.4.1
Development

Successfully merging this pull request may close these issues.

In-App browser can't download file on Download latest release button click
2 participants
@imblowfish @IraSoro