Every request starts a new client & connection

[jmreardon-yoppworks]

I've observed that every request to the IronCore server starts a new TCP (and therefore TLS connection) resulting in a time-consuming TLS handshake for every request. This appears to be due to ironoxide instantiations a new Client for every request:

ironoxide/src/internal/rest.rs

Line 536 in 95405fa

let client = Client::new();

Per the reqwest docs, the Client has it's own connection pool and it is expected to be instantiated once and be resued. It's possible the startup time for creating a new Client is slow as well.

[BobWall23]

We'll investigate adding the client to IronCoreRequest. We noticed this problem and fixed it in other products, but didn't check it here. Thanks for the report.

[skeet70]

We fixed this in #325, though in our benchmarks it didn't make a performance difference either way.