Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a lazy static reqwest client and use it #325

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

skeet70
Copy link
Member

@skeet70 skeet70 commented Sep 9, 2024

No description provided.

@skeet70
Copy link
Member Author

skeet70 commented Sep 10, 2024

The full sdk init happens before the benchmark run, so the client reuse should be coming into play here. Doesn't seem to make a significant difference.

main

document get metadata   time:   [377.59 ms 381.95 ms 386.62 ms]
                        change: [-6.3727% -3.8273% -1.2149%] (p = 0.01 < 0.05)
                        Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild

document encrypt [self] time:   [289.75 ms 292.48 ms 295.42 ms]
                        change: [-7.2391% -4.1039% -0.8954%] (p = 0.02 < 0.05)
                        Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild

document encrypt (unmanaged) [self]
                        time:   [10.209 ms 10.220 ms 10.232 ms]
                        change: [-5.7825% -5.4474% -5.1716%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  5 (5.00%) high mild

document encrypt [self, group]
                        time:   [589.78 ms 601.46 ms 615.63 ms]
                        change: [-0.7961% +2.8892% +6.8599%] (p = 0.42 > 0.05)
                        No change in performance detected.
Found 6 outliers among 100 measurements (6.00%)
  2 (2.00%) high mild
  4 (4.00%) high severe

document encrypt [self, group x 2]
                        time:   [582.30 ms 590.44 ms 601.29 ms]
                        change: [-6.3415% -3.3375% -0.1032%] (p = 0.01 < 0.05)
                        Change within noise threshold.
Found 12 outliers among 100 measurements (12.00%)
  8 (8.00%) high mild
  4 (4.00%) high severe

document decrypt [user] time:   [395.14 ms 399.78 ms 405.14 ms]
                        change: [-3.9206% +0.1059% +3.4110%] (p = 0.92 > 0.05)
                        No change in performance detected.
Found 10 outliers among 100 measurements (10.00%)
  6 (6.00%) high mild
  4 (4.00%) high severe

document decrypt (unmanaged) [group]
                        time:   [564.68 ms 595.34 ms 650.42 ms]
                        change: [+1.4632% +9.0657% +21.145%] (p = 0.15 > 0.05)
                        No change in performance detected.
Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) high mild
  1 (1.00%) high severe

document decrypt (unmanaged) [user]
                        time:   [386.11 ms 390.34 ms 394.97 ms]
                        change: [-5.0776% -2.2275% +0.3623%] (p = 0.09 > 0.05)
                        No change in performance detected.
Found 4 outliers among 100 measurements (4.00%)
  3 (3.00%) high mild
  1 (1.00%) high severe

group create            time:   [608.17 ms 615.57 ms 624.15 ms]
                        change: [-7.4591% -2.0614% +3.0807%] (p = 0.38 > 0.05)
                        No change in performance detected.
Found 9 outliers among 100 measurements (9.00%)
  6 (6.00%) high mild
  3 (3.00%) high severe

this branch

document get metadata   time:   [377.59 ms 381.95 ms 386.62 ms]
                        change: [-6.3727% -3.8273% -1.2149%] (p = 0.01 < 0.05)
                        Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild

document encrypt [self] time:   [289.75 ms 292.48 ms 295.42 ms]
                        change: [-7.2391% -4.1039% -0.8954%] (p = 0.02 < 0.05)
                        Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild

document encrypt (unmanaged) [self]
                        time:   [10.209 ms 10.220 ms 10.232 ms]
                        change: [-5.7825% -5.4474% -5.1716%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  5 (5.00%) high mild

document encrypt [self, group]
                        time:   [589.78 ms 601.46 ms 615.63 ms]
                        change: [-0.7961% +2.8892% +6.8599%] (p = 0.42 > 0.05)
                        No change in performance detected.
Found 6 outliers among 100 measurements (6.00%)
  2 (2.00%) high mild
  4 (4.00%) high severe

document encrypt [self, group x 2]
                        time:   [582.30 ms 590.44 ms 601.29 ms]
                        change: [-6.3415% -3.3375% -0.1032%] (p = 0.01 < 0.05)
                        Change within noise threshold.
Found 12 outliers among 100 measurements (12.00%)
  8 (8.00%) high mild
  4 (4.00%) high severe

document decrypt [user] time:   [395.14 ms 399.78 ms 405.14 ms]
                        change: [-3.9206% +0.1059% +3.4110%] (p = 0.92 > 0.05)
                        No change in performance detected.
Found 10 outliers among 100 measurements (10.00%)
  6 (6.00%) high mild
  4 (4.00%) high severe

document decrypt (unmanaged) [group]
                        time:   [564.68 ms 595.34 ms 650.42 ms]
                        change: [+1.4632% +9.0657% +21.145%] (p = 0.15 > 0.05)
                        No change in performance detected.
Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) high mild
  1 (1.00%) high severe

document decrypt (unmanaged) [user]
                        time:   [386.11 ms 390.34 ms 394.97 ms]
                        change: [-5.0776% -2.2275% +0.3623%] (p = 0.09 > 0.05)
                        No change in performance detected.
Found 4 outliers among 100 measurements (4.00%)
  3 (3.00%) high mild
  1 (1.00%) high severe

group create            time:   [608.17 ms 615.57 ms 624.15 ms]
                        change: [-7.4591% -2.0614% +3.0807%] (p = 0.38 > 0.05)
                        No change in performance detected.
Found 9 outliers among 100 measurements (9.00%)
  6 (6.00%) high mild
  3 (3.00%) high severe

@skeet70 skeet70 merged commit 330dafe into main Sep 10, 2024
18 checks passed
@skeet70 skeet70 deleted the reuse-reqwest-client branch September 10, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants