Enable fast feature of ed25519-dalek
#190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coltfred
reviewed
Dec 5, 2024
benches/api_benchmark.rs
Outdated
| use recrypt::api_480::Ed25519Ops as Ed25519Ops480; | ||
| use recrypt::api_480::KeyGenOps as KeyGenOps480; | ||
| use recrypt::api_480::Recrypt480; | ||
| // use recrypt::api_480::CryptoOps as CryptoOps480; |
There was a problem hiding this comment.
I don't really want all of these commented out as it makes it less clear how to run the 480 benches. Did you comment them out for a specific reason?
There was a problem hiding this comment.
Just to avoid the dead code analysis on the recrypt_bench! line below. I could add it back in if you prefer
coltfred
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a performance regression introduced in 0.14.0 around generating ed25519 keypairs. It will now utilize precomputer basepoint multiplication tables.