clang-tidy and g_ API conversions #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standard C99. { 0 } is somewhat interesting as some compilers warn about
uninitialized members, which is bogus.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with clang-analyzer-unix.Malloc Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with bugprone-assignment-in-if-condition Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with readability-redundant-casting Signed-off-by: Rosen Penev <rosenp@gmail.com>
These should not fail. There are no null checks. Signed-off-by: Rosen Penev <rosenp@gmail.com>
This just gets freed at the end after getting copied. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with -Wanalyzer-null-argument Signed-off-by: Rosen Penev <rosenp@gmail.com>
Now matches sun_path size. Found with -Wanalyzer-out-of-bounds Signed-off-by: Rosen Penev <rosenp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the code