Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Fix/anchor encoding #79

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Fix/anchor encoding #79

merged 2 commits into from
Jan 16, 2024

Conversation

JesseTheRobot
Copy link
Member

This PR fixes DataItem & FileDataItem get anchor() returning rawAnchor.toString() instead of base64url.encode(rawAnchor)
additionally, this PR includes:

  • addition and usage of Base64URLString utility alias type
  • updates to all relevant tests
  • addition of src/ to release package so that emitted sourceMaps function correctly

…ng without base64url encoding

Fixes DataItem & FileDataItem get anchor() returning rawAnchor.toString() instead of base64url.encode(rawAnchor). includes updates to all relevant tests
Copy link
Collaborator

@joshbenaron joshbenaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesseTheRobot JesseTheRobot merged commit 5db54ee into master Jan 16, 2024
2 checks passed
@JesseTheRobot JesseTheRobot deleted the fix/anchor-encoding branch January 16, 2024 21:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants