Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Migrate to @aptos-labs/ts-sdk #120

Merged

Conversation

0xmaayan
Copy link
Contributor

@0xmaayan 0xmaayan commented Feb 15, 2024

resolves https://github.com/Irys-xyz/js-sdk/issues/119

Aptos has a new TS SDK and it is encouraged to migrate over to the new one for a better support and project integrations.

Note:
I tested the e2e Irys flow locally using local builds. I couldn't find any tests or documentation regarding contribution steps. Please let me know if anything else is needed to complete the pull request.

Some feedback to share while working on the irys source code:

  1. Could be nice to type the input arguments to be easily used by other projects, for reference https://github.com/Irys-xyz/js-sdk/blob/main/src/node/base.ts#L93
  2. Having the service full url we just uploaded files/folder to as part of the response can be very helpful
type UploadResponse = {
....
url:""
}

@JesseTheRobot JesseTheRobot self-assigned this Feb 15, 2024
@JesseTheRobot JesseTheRobot self-requested a review February 15, 2024 21:18
Copy link

@jillxuu jillxuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm my my end as long as we've tested locally e2e irys works well with our ts sdk v2. i'll let @JesseTheRobot to stamp on this PR since its irys codebase.

@JesseTheRobot: prob clean the codebase a bit? saw a lot of commented out code, if not needed, just remove them

@JesseTheRobot JesseTheRobot changed the base branch from main to feat/aptos-sdk-upgrade February 27, 2024 22:55
@JesseTheRobot
Copy link
Member

I changed the base branch so I can merge it and perform a couple fixes - I'll update here with the new PR tracking the final merge & release once said fixes are made

@JesseTheRobot JesseTheRobot merged commit 783a375 into Irys-xyz:feat/aptos-sdk-upgrade Feb 27, 2024
JesseTheRobot added a commit that referenced this pull request Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Aptos TS SDK Integration
3 participants