Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

refactor: add each user tag to the tags #82

Closed
wants to merge 7 commits into from
Closed

refactor: add each user tag to the tags #82

wants to merge 7 commits into from

Conversation

jshaw-decides
Copy link
Contributor

  • added userTags?: {name: string, value: string}[] to the uploadFolder interface.
  • adding tags to tx via tags.forEach(t => tags.push(t))

Let me know if you need me to run any tests or any other way I can help get this in there.

Copy link
Member

@JesseTheRobot JesseTheRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor tweaks

src/node/bundlr.ts Outdated Show resolved Hide resolved
src/node/upload.ts Outdated Show resolved Hide resolved
src/node/upload.ts Outdated Show resolved Hide resolved
@JesseTheRobot JesseTheRobot self-requested a review March 14, 2023 15:20
Copy link
Member

@JesseTheRobot JesseTheRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last few changes

src/node/upload.ts Outdated Show resolved Hide resolved
src/node/bundlr.ts Show resolved Hide resolved
@joshbenaron
Copy link
Contributor

Can someone clearly state API changes here? @JesseTheRobot @mogulx-operates

@JesseTheRobot
Copy link
Member

Can someone clearly state API changes here? @JesseTheRobot @mogulx-operates

Sure, so this just adds an optional manifestTags tag array option to folderUploader , that as the name suggests adds user defined tags to the manifest itself. apparently this is used for ANS-110

@jshaw-decides
Copy link
Contributor Author

jshaw-decides commented Mar 15, 2023

Can someone clearly state API changes here? @JesseTheRobot @mogulx-operates

@joshbenaron this is the the specific use case.

  • the folder being uploaded is a "discoverable (ANS-110) renderer (ANS-108)".

So I'm going to add ANS-110 tags to the manifest with Type "renderer".

Updated link because the one I gave you didn't say much ⬇️

https://github.com/mogulx-operates/arweave-standards/blob/ans-111/ans/ANS-111.md

Sample query:

query {
  transactions(
      first: 100,
        tags: [
          { name: "Type", values: ["renderer"] },
          { name: "Render-For", values: ["blog-post"] },
        ]) {
      edges {
          node {
              id
                owner {
                  address
                }
                tags {
                  name
                    value
                }
        }}
    }
}

Copy link
Member

@JesseTheRobot JesseTheRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jshaw-decides jshaw-decides deleted the pass-user-tags-to-upload-folder branch March 19, 2023 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants