Using carapace in Travis build #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whikloj
approved these changes
Jun 28, 2017
This was referenced Jun 28, 2017
Merged
dannylamb
pushed a commit
to dannylamb/CLAW
that referenced
this pull request
Feb 8, 2018
* Changed hook_preprocess_HOOK() to template_preprocess_HOOK() * Changed hook_preprocess_HOOK() to template_preprocess_HOOK() * Changed hook_preprocess_HOOK() to template_preprocess_HOOK() * Modified comments to say template_preprocess_Hook() * Changed _Hook to upper case in comments in 3 spots. * Changed hook_preprocess() to template_preprocess_HOOK() * Changed hook_preprocess() to template_preprocess_HOOK() * Changed hook_preprocess() to template_preprocess_HOOK()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #670
What does this Pull Request do?
This is a short-term fix to deal with the fact that exporting blocks ties you to the theme. Long-term we need to figure out a solution to decouple us from any particular theme.
What's new?
Copy/paste from claw_vagrant to set up Carapace.
How should this be tested?
After this is merged we need to re-run the tests for islandora_collection and make sure they pass.
Interested parties
Any @Islandora-CLAW/committers feeling lucky?