Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update travis build to use Carapace #670

Closed
dannylamb opened this issue Jun 28, 2017 · 2 comments
Closed

Update travis build to use Carapace #670

dannylamb opened this issue Jun 28, 2017 · 2 comments

Comments

@dannylamb
Copy link
Contributor

Now that https://github.com/Islandora-CLAW/islandora_collection/pull/22 has been merged, we need to update the Travis builds to use the Carapace theme or the islandora module won't install properly.

Should be a quick fix right here a la this PR from @bryjbrown.

This is a quick fix for now, and we'll have to update it again once carapace goes composer.

@dannylamb
Copy link
Contributor Author

Or maybe not. I'm going to investigate removing the theme dependency from the block and seeing what happens. My suspicion is that it is available, but not "placed" through the Drupal UI.

@dannylamb
Copy link
Contributor Author

So that won't work. I threw up a quick PR as duct tape until we can figure out a long term solution that decouples us from themes.

This was referenced Jun 28, 2017
dannylamb pushed a commit to dannylamb/CLAW that referenced this issue Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant