Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

Downloads and enables carapace theme and deps #48

Merged
merged 3 commits into from
Jun 26, 2017
Merged

Downloads and enables carapace theme and deps #48

merged 3 commits into from
Jun 26, 2017

Conversation

bryjbrown
Copy link
Contributor

@bryjbrown bryjbrown commented Jun 22, 2017

GitHub Issue: Islandora/documentation#644

What does this Pull Request do?

Replaces installation of Bootstrap as the default theme with Carapace (and dependencies).

How should this be tested?

Boot up the VM, localhost:8000 looks different.

Additional Notes:

This is being installed via drush --pm-force and git clone, even though the correct way is to use composer. I'll integrate this with composer better in the future, but this works okay for now.

Interested parties

@dannylamb @Favenzio @rosiel

# Set default theme to carapace (and download dependencies, will composer-ize later)
$DRUSH_CMD --pm-force dl -y adaptivetheme
$DRUSH_CMD --pm-force dl -y at_tools
$DRUSH_CMD --pm-force dl -y layout_plugin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So these 3 lines will have to go into drupal-project eventually, but you can replace them here with

cd $DRUPAL_HOME
composer require "drupal/adaptivetheme:^2.0" "drupal/at_tools:^2.0" "drupal/layout_plugin:^1.0@alpha"

For reference I figured out the numbers from the individual project pages on drupal.org (removing the 8.x-)

I'll check out @Favenzio's theme next 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The drush --pm-force dl calls have been replaced with composer require in 532c02c

@whikloj
Copy link
Contributor

whikloj commented Jun 23, 2017

vagrant up

Copy link
Contributor

@whikloj whikloj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

@whikloj
Copy link
Contributor

whikloj commented Jun 23, 2017

@dannylamb do you want to wait for carapace to move to a foundation organization before we use it? Would it be better to move it to a labs repo so @Favenzio, @rosiel and all the other UI people could work it more freely. We could just pin claw_vagrant to a tag.

Thoughts?

@dannylamb
Copy link
Contributor

dannylamb commented Jun 26, 2017

@whikloj We deciding in the UIIG meeting to pull it into the CLAW organization and work on it there. I made Islandora/documentation#667 to track it and assigned it to @Favenzio. I also updated the dependencies in this PR.

@dannylamb
Copy link
Contributor

@bryjbrown The repo has been brought over to the claw org. If you can update your git clone command, we'll get this merged in.

@bryjbrown
Copy link
Contributor Author

@dannylamb should already be done now.

@dannylamb
Copy link
Contributor

@bryjbrown Gah... sorry. Missed that you had already done it due to browser caching.

@whikloj Feel free to merge if you're comfortable with the changes.

@whikloj whikloj merged commit 132d548 into islandora-deprecated:master Jun 26, 2017
@ruebot
Copy link
Contributor

ruebot commented Jun 28, 2017

Unable to install islandora_collection due to unmet dependencies: block.block.views_block__membership_view_block_1 (bootstrap)

Can't enable Islandora Collection and Islandora Image with this theme.

ruebot added a commit to yorkulibraries/islandora_collection that referenced this pull request Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants