Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove matomo #153

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Remove matomo #153

merged 7 commits into from
Jun 5, 2024

Conversation

joecorall
Copy link
Contributor

@joecorall joecorall commented May 29, 2024 •
edited
Loading

Remove matomo module from the starter site.

I was hoping the CI would help detect any regressions with site install after removing matomo, but the CI job wasn't producing useful output since drush config:inspect was not able to complete due to some incorrect data types in our config export. So fixed those, too, so at least that job shows some meaningful output (which we should work to correct, but beyond the scope of this PR).

CI before

Screen Shot on 2024-05-29 at 09-42-10

CI after

Screen Shot on 2024-05-29 at 09-40-57

joecorall added 3 commits May 29, 2024 09:01
@joecorall
rm matomo
767ff7d
@joecorall
Fixup CI
b73349e 
- Only run once on PRs
- Test php 8.3
- Set shell so failures fail the job
@joecorall
Allow config inspector to atleast complete
cefbd8c
@joecorall joecorall marked this pull request as ready for review May 29, 2024 13:43
@joecorall joecorall requested a review from a team May 29, 2024 13:43
@aOelschlager aOelschlager self-requested a review May 29, 2024 17:27
@joecorall joecorall mentioned this pull request Jun 3, 2024
Merged
aOelschlager
aOelschlager approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@aOelschlager aOelschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to install the starter site with no issues and I didn't see any errors in the logs.

@aOelschlager aOelschlager merged commit 77abc2f into main Jun 5, 2024
3 checks passed
@aOelschlager aOelschlager deleted the matomo branch June 5, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aOelschlager aOelschlager aOelschlager approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joecorall @aOelschlager