WIP: Re-enabling S3 storage for Fedora 6 #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigelgbanks
reviewed
Apr 1, 2021
| export CATALINA_OPTS="${CATALINA_OPTS} -Dfcrepo.storage=ocfl-fs" | ||
| fi | ||
| if [[ "${FCREPO_BINARYSTORAGE_TYPE}" == "s3" ]]; then | ||
| export CATALINA_OPTS="${CATALINA_OPTS} -Dfcrepo.storage=ocfl-s3 -Dfcrepo.aws.region=${FCREPO_AWS_REGION} -Dfcrepo.aws.region=${FCREPO_S3_BUCKET} -Dfcrepo.aws.region=${FCREPO_S3_PREFIX}" |
There was a problem hiding this comment.
Does the user name / password not need to be passed in as well?
There was a problem hiding this comment.
Probably so. Hertzel was testing this today...
|
I don't have the ability to test this at the moment but it looks safe for merging, I'll wait for a yea or neigh 🐴 til Monday |
|
@emudojo is testing this over the next few days - we'll give you a 👍 when it's ready |
Oh ok I'll move the pull request into draft in the mean while 👍 |
|
Closing as #134 was opened |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #129 it appears that only F5 can write to S3, so I have started the process of enabling F6 to write to S3.