Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the TAG/DRUPAL_INSTALL_PROFILE #244

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

DonRichards
Copy link
Member

Currently, these are breaking the build. Likely because an install profile PR hasn't been merged yet. This is to set it back to a workable option.

To test

  • Prior to switching to this PR try to build from a clean state. In other words, run make clean.
  • Run make up or make local

If it properly builds without issue this would be a successful test.

@noahwsmith
Copy link
Contributor

#160 was merged. Not sure why this is throwing this error...

@DonRichards
Copy link
Member Author

DonRichards commented Apr 5, 2022

Yeah, I noticed but it introduces a problem. This PR is likely just a temporary fix to just get it to build. I suspect the issue is with the tag. Probably just need a different tag set. Although I prefer the install profile, I can't seem to get "islandora_install_profile_demo" to build properly from a clean state without making these changes. From what I'm seeing in chat and PR reviews this has become a blocker.

@misilot
Copy link
Contributor

misilot commented Apr 5, 2022

@noahwsmith I think it might be because of this PR Islandora-Devops/isle-buildkit#170 and not #160

@seth-shaw-unlv seth-shaw-unlv self-requested a review April 6, 2022 17:45
Copy link

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves the build issues I was experiencing. We'll run with it until the referenced build-kit PR gets in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants