Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify starter site version in sample.env #352

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

joshdentremont
Copy link
Contributor

starter site needs to be installed at version 0.8.0 in order to be compatible with Isle 1.0.10.

Once we are ready to bump the default TAG to 2.0.0 or higher we will need to bump starter site as well to get Drupal 10.

@rosiel
Copy link
Contributor

rosiel commented Aug 2, 2023

I think this should be ~0.8.0 which would allow any release up to (but not including) 1.0.0. This will take us out of the (IMO bad) habit of locking things down to specific versions which prevents updates from ever getting applied.

(Generally we use the caret operator e.g. ^0.8 but for pre-1.0.0 releases the caret treats every middle digit like its own major release)

@rosiel
Copy link
Contributor

rosiel commented Aug 2, 2023

On second thought, since this is breaking and there's unlikely to be another pre-1.0 release, I'll merge it with the vocal caveat that we should be specifying all-non-breaking-changes going forwards.

@rosiel rosiel merged commit cf87d4d into Islandora-Devops:development Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants