GitHub actions #113
Merged
GitHub actions #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whikloj
reviewed
Apr 29, 2021
| @@ -1,10 +1,10 @@ | |||
| #  Crayfish | |||
|
|
|||
| [](https://php.net/) | |||
| [](https://travis-ci.com/Islandora/Crayfish) | |||
| [](https://github.com/Islandora/Crayfish/actions) | |||
There was a problem hiding this comment.
You are not the first to do this, but I ask this question everytime. Does our main branch have a purpose or has the dev branch now just become main and the actual main branch could be turfed?
There was a problem hiding this comment.
Dev is the default branch on GitHub so that’s why I did that but I am probably wrong. @dannylamb ?
There was a problem hiding this comment.
I don't think your wrong, but if we tag a commit in dev as a release then I am just wondering if we even need main anymore? I'll merge this and we could consider removing that branch entirely. No one is working against it.
|
Rather I won't merge it, but let @dannylamb know that he can once he updates the "required status" here too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: (Islandora/documentation#1798)
What does this Pull Request do?
Converts to github actions
updates the badges
removes travis
What's new?
How should this be tested?
passed here:
https://github.com/asulibraries/Crayfish/runs/2462160374?check_suite_focus=true#step:9:42
and codecov should be running as well (proof here https://codecov.io/gh/asulibraries/Crayfish/commit/67a862c0d4e086d22f2496e06e0e82e52728b6b7/)
Interested parties
@Islandora/8-x-committers