Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using file url for media #68

Merged
merged 2 commits into from
May 23, 2019
Merged

Using file url for media #68

merged 2 commits into from
May 23, 2019

Conversation

dannylamb
Copy link
Contributor

GitHub Issue: Part of Islandora/documentation#662

Goes with Islandora/documentation#136 and https://github.com/Islandora-CLAW/islandora_demo/pull/29

What does this Pull Request do?

Passes in the Drupal url from Gemini instead of trying to reconstruct it (which was brittle and failing) when saving RDF. This way, nodes and media work the same, despite having very different subject urls.

How should this be tested?

See Islandora/documentation#136

Interested parties

@whikloj @Islandora-CLAW/committers

@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #68   +/-   ##
=========================================
  Coverage     94.59%   94.59%           
  Complexity      159      159           
=========================================
  Files             9        9           
  Lines           647      647           
=========================================
  Hits            612      612           
  Misses           35       35
Impacted Files Coverage Δ Complexity Δ
Milliner/src/Service/MillinerService.php 99.56% <100%> (ø) 49 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38c5016...52aeeb7. Read the comment docs.

@whikloj
Copy link
Member

whikloj commented May 23, 2019

👀

Copy link
Member

@whikloj whikloj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@whikloj whikloj merged commit bf50656 into Islandora:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants