Added authorization. #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajstanley So the 512 character limit is not an issue? |
|
@whikloj -It doesn't seem to be. The character limit came up in a discussion group, but I was unable to find any other reference to it. This one works for me. |
elizoller
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: (Islandora/documentation#1447)
What does this Pull Request do?
FFMpeg had been failing on files that were not visible to anonymous viewers. This adds token-based authentication.
What's new?
Not much. I grabbed the token from the incoming request object and jammed it (© Danny Lamb ) into ffmpeg as a header.
How should this be tested?
Create an Audio media in a non-open filesystem. A service file should generate. If there are any problems you'll see them in the homarus.log
Interested parties
@Islandora/8-x-committers @Natkeeran @dannylamb