Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #99

Merged
merged 6 commits into from
Apr 26, 2023
Merged

Update dependencies #99

merged 6 commits into from
Apr 26, 2023

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Mar 27, 2023

What does this Pull Request do?

Makes the __construct function private, so you must use the create method. We need to start storing the base_uri in our FedoraApi instance as Guzzle is deprecating access to the getConfig() method. So passing in a pre-built Guzzle will no longer allow us to determine the base_uri.

That is why this PR is against the new 2.x branch as this will be a backwards breaking change.

*** This PR is FIRST in the chain of work ***

Dependant PRs:

What's new?

  1. Makes constructor private as described above
  2. Changes in Github Actions to support Node16
  3. Replaces Mockery with mock-webserver as we can't mock Guzzle response anymore so we needed a different way to test, hence mock-webserver.
  4. Adds type hinting
  5. Moves the tests into their own separate namespace.
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? yes, if it passes in a pre-built Guzzle

How should this be tested?

This has no real change in functionality, but there are dependant PRs that will be listed above.

Documentation Status

  • Does this change existing behaviour that's currently documented? no
  • Does this change require new pages or sections of documentation? no
  • Who does this need to be documented for?
  • Associated documentation pull request(s): ___ or documentation issue ___

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

whikloj added 4 commits March 27, 2023 15:02
Update php requirement

Update test dependencies

We need the base uri passed in to store it.

Fix actions

Remove mockery
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: +5.19 🎉

Comparison is base (42a35da) 94.80% compared to head (21b25fb) 100.00%.

Additional details and impacted files
@@              Coverage Diff              @@
##                2.x       #99      +/-   ##
=============================================
+ Coverage     94.80%   100.00%   +5.19%     
  Complexity       20        20              
=============================================
  Files             2         1       -1     
  Lines            77       111      +34     
=============================================
+ Hits             73       111      +38     
+ Misses            4         0       -4     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seth-shaw-asu
Copy link
Member

@whikloj , step 1 complete. What's next?

@whikloj
Copy link
Member Author

whikloj commented Apr 26, 2023

We need to tag a 2.0.0 release of Chullo. I'll create a 1.0.0 release of https://github.com/Islandora/islandora-fedora-entity-mapper. Then I'll update the other PRs where necessary.

@whikloj whikloj deleted the update-dependencies branch April 26, 2023 21:35
@whikloj
Copy link
Member Author

whikloj commented Apr 26, 2023

Actually, maybe you should test Islandora/Crayfish#174 and Islandora/islandora#936 before I start cutting versions of https://github.com/Islandora/islandora-fedora-entity-mapper

@seth-shaw-asu
Copy link
Member

Weren't those included in Islandora-Devops/islandora-playbook#263? That is what I used to test, so they should be ready to approve, although the islandora one will need composer.json references updated, right?

@whikloj
Copy link
Member Author

whikloj commented Apr 27, 2023

Yes...I guess I'm just being paranoid. Okay, so I'll tag a 1.0.0 release of the entity mapper.

@whikloj
Copy link
Member Author

whikloj commented Apr 27, 2023

Actually I have no permissions on https://github.com/Islandora/islandora-fedora-entity-mapper so if someone could setup the committer teams to have access please.

@whikloj
Copy link
Member Author

whikloj commented Apr 27, 2023

I tagged a 2.0.0 release of chullo though

@seth-shaw-asu
Copy link
Member

@whikloj , I just added the committers as maintainers on the repo, so you should be able to tag the release now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants