-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #99
Conversation
Update php requirement Update test dependencies We need the base uri passed in to store it. Fix actions Remove mockery
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #99 +/- ##
=============================================
+ Coverage 94.80% 100.00% +5.19%
Complexity 20 20
=============================================
Files 2 1 -1
Lines 77 111 +34
=============================================
+ Hits 73 111 +38
+ Misses 4 0 -4 see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@whikloj , step 1 complete. What's next? |
We need to tag a |
Actually, maybe you should test Islandora/Crayfish#174 and Islandora/islandora#936 before I start cutting versions of https://github.com/Islandora/islandora-fedora-entity-mapper |
Weren't those included in Islandora-Devops/islandora-playbook#263? That is what I used to test, so they should be ready to approve, although the islandora one will need composer.json references updated, right? |
Yes...I guess I'm just being paranoid. Okay, so I'll tag a 1.0.0 release of the entity mapper. |
Actually I have no permissions on https://github.com/Islandora/islandora-fedora-entity-mapper so if someone could setup the committer teams to have access please. |
I tagged a |
@whikloj , I just added the committers as maintainers on the repo, so you should be able to tag the release now. |
What does this Pull Request do?
Makes the
__construct
functionprivate
, so you must use thecreate
method. We need to start storing thebase_uri
in ourFedoraApi
instance as Guzzle is deprecating access to the getConfig() method. So passing in a pre-built Guzzle will no longer allow us to determine thebase_uri
.That is why this PR is against the new 2.x branch as this will be a backwards breaking change.
*** This PR is FIRST in the chain of work ***
Dependant PRs:
What's new?
(i.e. Regeneration activity, etc.)? no
How should this be tested?
This has no real change in functionality, but there are dependant PRs that will be listed above.
Documentation Status
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers