Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content types become taxonomies #8

Merged
merged 6 commits into from
Sep 6, 2018
Merged

content types become taxonomies #8

merged 6 commits into from
Sep 6, 2018

Conversation

seth-shaw-unlv
Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv commented Aug 31, 2018

GitHub Issue:

  • #902: Convert controlled_access_terms config into a feature
  • #912: controlled_access_terms content types as taxonomies
  • #915: Fix controlled_access_terms TypedRelations validateValues

What does this Pull Request do?

This PR incorporates @whikloj's work moving the configs into a feature, a bug-fix for the TypedRelations field, and turning the Agents and Subjects into taxonomy vocabularies.

How should this be tested?

From a clean install:

  • Apply the PR
  • Enabling the main Controlled Access Terms module will make the TypedRelation and AuthorityLink available.
  • Enabling the Default Configuration sub-module will install the configs to create taxonomy vocabularies for Corporate Bodies, Persons, Families, Geographic Locations, and Subjects.
  • Creating a term for any of them should not cause errors.
  • Also, adding a TypedRelation field and then updating the default available relation types shouldn't WSOD.

Additional Notes:

I neglected to add a typed relation field before issuing the PR. One will come shortly.

This PR supersedes #6 and #7.

Interested parties

@Islandora-CLAW/committers (esp. @whikloj and @Natkeeran)

@seth-shaw-unlv seth-shaw-unlv changed the title Issue 912 content types become taxonomies Aug 31, 2018
@Natkeeran
Copy link
Contributor

@seth-shaw-unlv

I am at the last step. Adding TypedRelation field to Repository Item. I choose Taxonomy term for "Type of item to reference". In the Reference Type I choose "Geographic Location". I am wondering what to put into "Available Relations"?

@seth-shaw-unlv
Copy link
Contributor Author

I haven't looked into relationship predicates for Geo, just Agents. For the Object-Agent relators we are pulling our list from MARC and it looks like:

relators:abr|Abridger (abr)
relators:act|Actor (act)
relators:adp|Adapter (adp)
relators:rcp|Addressee (rcp)
relators:anl|Analyst (anl)
relators:anm|Animator (anm)
relators:ann|Annotator (ann)

(and on for ~260 more options).

For the purposes of testing, you could just use those.

@dannylamb
Copy link
Contributor

@Natkeeran If you're ok with this, please feel free to merge.

@Natkeeran Natkeeran merged commit 66bab1a into Islandora:8.x-1.x Sep 6, 2018
@Natkeeran
Copy link
Contributor

@seth-shaw-unlv @dannylamb Looks good.

For geography, I assume it would be something like birthPlace, placeOfPublication etc? That is for another discussion.

@seth-shaw-unlv seth-shaw-unlv deleted the issue-912 branch September 6, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants