Remove comments about WebAC #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebAC is not used but is listed as a feature added when using Fedora. Although it is there, I'd suggest leaving off of this documentation.
|
I think that line should stay in since this is giving a view of what Fedora can do, not what Islandora is doing with Fedora. |
|
Shoulda refreshed, didn't see @bseeger 's comments |
|
@bseeger What about adding comments to indicate that Islandora doesn't leverage this by default? |
|
@DonRichards I think adding a note that it's not currently leveraged by default in islandora sounds like a good compromise. |
|
We'll need this PR re-rolled against |
|
I learned over in Fedora that if you Edit the PR (button at the top), you can change the branch it is against. |
|
I'm also happy to redo this one as a note instead of a deletion. Your call, @DonRichards |
|
@manez Sorry I been distracted and didn't see the activity on this PR. Yes I can move it. |
|
@manez @bseeger @whikloj @dannylamb |
manez
approved these changes
Aug 31, 2020
dannylamb
pushed a commit
that referenced
this pull request
Sep 11, 2020
* Remove comments about WebAC WebAC is not used but is listed as a feature added when using Fedora. Although it is there, I'd suggest leaving off of this documentation. * Update user-intro.md
whikloj
pushed a commit
that referenced
this pull request
Sep 30, 2020
* Render the example helpful tip properly. (#1586) * Render the example helpful tip properly. * Fix note syntax, again. * Mention the User Call (#1587) * Update rdf-mapping.md doc (#1585) * Update committers.md (#1592) * Fix committer nomination email address (#1593) * Fix old email address. * Update closeCommitterVote.txt * De-CLAW * De-CLAW * DeCLAW * Change email * De-CLAW * Update travis for the main branch switch (#1594) * Master -> Main Rename * Remove comments about WebAC (#1555) * Remove comments about WebAC WebAC is not used but is listed as a feature added when using Fedora. Although it is there, I'd suggest leaving off of this documentation. * Update user-intro.md * Add more details about starting up an islandora. (#1597) * Add more details about starting up an islandora. * Update index.md * Mention use of dev branch for prebuilt base box * Update index.md * Fix typo in VBE * Make clearer the different levels of sandbox reqs. * Update CONTRIBUTING.md (#1601) * Add Jordan to committers list (#1602) * Migration docs updates (#1603) * Added link to newer migration Youtube vid, added migration-overview.md * Replaced used of "*" with "-" for bulleted lists * Updated headings in docs and spelling changes * Main update (#1612) * Render the example helpful tip properly. (#1586) * Render the example helpful tip properly. * Fix note syntax, again. * Update rdf-mapping.md doc (#1585) Co-authored-by: Eli Zoller <5439169+elizoller@users.noreply.github.com> * Merge changes to add @manez to committers. (#1613) * Merge changes to add @manez to committers. * Alphabeticalize committer names. Co-authored-by: dannylamb <dlamb@islandora.ca> * De-CLAWing * Derp * Missing parenthesis Co-authored-by: Rosie Le Faive <lefaive@gmail.com> Co-authored-by: Eli Zoller <5439169+elizoller@users.noreply.github.com> Co-authored-by: Jonathan Green <jonathan.green@lyrasis.org> Co-authored-by: Don Richards <DonRichards@utk.edu> Co-authored-by: Melissa Anez <manez@islandora.ca> Co-authored-by: Yamil <ysuarez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebAC is not used but is listed as a feature added when using Fedora. Although it is there, I'd suggest leaving off of this documentation.
GitHub Issue: None
What does this Pull Request do?
Clarifies documentation on WebAC
What's new?
Doc removing WebAC as a featured added by including Fedora
How should this be tested?
N/A
Additional Notes:
N/A
Interested parties
@Islandora/8-x-committers