Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migrate-csv.md to address #1834 #1836

Closed
wants to merge 1 commit into from
Closed

Update migrate-csv.md to address #1834 #1836

wants to merge 1 commit into from

Conversation

manez
Copy link
Member

@manez manez commented May 27, 2021

Purpose / why

#1834 says docs need to tell you to import the feature after enabling the module.

What changes were made?

One more line of instructions,

Verification

Verify that this step is correct and happens in the right place.

Interested Parties

@Islandora/documentation @dannylamb is this right?


Checklist

Pull-request reviewer should ensure the following

  • Does this PR link to related issues?
  • Does the proposed documentation align with the Islandora Documentation Style Guide?
  • Are the changes accurate, useful, free of typos, etc?
  • Does this PR update the last updated on date on the documentation page?

Person merging should ensure the following

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@@ -90,6 +90,7 @@ From your `islandora-playbook` directory, issue the following commands to enable
- `cd /var/www/html/drupal/web/modules/contrib` to get to your modules directory.
- `git clone https://github.com/Islandora/migrate_islandora_csv` to clone down the repository from GitHub.
- `drush en -y migrate_islandora_csv` to enable the module, installing the migrations as configuration.
- `drush fim migrate_islandora_csv` to import the feature.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing a feature import right after installation won't do anything (as the installation already added the current state of the configs).

Instead, we use the drush fim command to push config changes into Drupal.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we need a new heading of "Making Changes to Migrations" where we note both the Drush features:import command (as we demonstrate here) and using the Configuration Synchronization UI for single item updates.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I understand that part well enough to write it, but I'm happy to make the changes if some one can give me the words 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manez manez closed this Jun 1, 2021
@manez
Copy link
Member Author

manez commented Jun 1, 2021

Wrong advice, which doesn't work anyway :/

@rosiel rosiel deleted the manez-csv branch August 30, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants