Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #1005
I've tested this and Islandora's code still runs without errors.
The DGI Fixity module still requires 2.x so we're keeping it in here (also makes it compatible with Drupal < 10.2)
What does this Pull Request do?
Allows Filehash 3
What's new?
(i.e. Regeneration activity, etc.)? no
How should this be tested?
Put a breakpoint around https://github.com/Islandora/islandora/blob/2.x/islandora.module#L186 and see that you can still access those "fields" on the file entity, and that they return the appropriate checksums.
Also I noted that as before, if you look at the Content > Files list (and edit the view to add Original SHA-1 and SHA-1), any media created by derivatives has a null Original SHA-1.
Documentation Status
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers