Follow-up on caching Height and Width on the media: Add config schema for new Action, and adjust wording.

[rosiel]

GitHub Issue: n/a

• Other Relevant Links (Google Groups discussion, related pull requests,
  Release pull requests, etc.)

#1029

What does this Pull Request do?

A little housekeeping, creating a config schema, and some rewording

What's new?

• Config schema.

• Wording changes

  • In the Actions config page, there's a blurb at the top talking about how there are "simple" and "advanced" actions. Since this is the terminology used by Drupal, I changed "complex" to "advanced".
  • When talking about the Media Use to do this action on, I removed the word "Source". It implies a "destination" and more confusingly, implies that the destination is not the source. What we're actually selecting is "the Media to do the thing to", being both Source and Destination.
  • Removed hard coded references to Original File (in comments/documentation) since you could do this to any media. (Admittedly, in our standard config, Original File makes the most sense)

• It looks like there was a stray 'media_use_term' that was later renamed to 'source_term_uri'.

• Does this change add any new dependencies? nope

• Does this change require any other modifications to be made to the repository
  (i.e. Regeneration activity, etc.)? nope

• Could this change impact execution of existing code? nope

How should this be tested?

Due to the nature of the all-string config schema, as well as the useful dropdown list to choose from, you could do what I did and mess with the schema (change one value to Boolean) then inspect the saved config in Devel's Config Editor or however you like to inspect your configs. In my case, the value stored was "True".

Documentation Status

• Does this change existing behaviour that's currently documented? this changes documentation about existing behaviour.
• Does this change require new pages or sections of documentation? Yeah maybe there could be a page in the docs.
• Who does this need to be documented for? site managers getting frustrated with IIIF slowness.
• Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

[aOelschlager]

I just tested this and it works. I had to update the database because of schema change.