Remove required from condition plugin forms #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joecorall
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Thank you! We're running google tag on our site and had to do some weird config export/edit/import to get around this problem. Tested this locally and it works as intended. Can now just edit the google tag settings in the UI.
Closes #1065
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Condition Plugins are optional and only enabled when required. Config forms for these plugins should not have required fields.
GitHub Issue: (link)
#1065
Release pull requests, etc.)
What does this Pull Request do?
Makes config for condition plugins optional.
No
How should this be tested?
Install either google_tag or asset_injector.
Try saving the google tag form or the asset injector form.
These forms can't be saved without this PR
Interested parties
@Islandora/committers