Fix travis #804
Closed
Fix travis #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannylamb
reviewed
Oct 22, 2020
| - $SCRIPT_DIR/run-tests.sh "islandora_text_extraction" | ||
|
|
||
| after_success: | ||
| - bash <(curl -s https://codecov.io/bash) |
There was a problem hiding this comment.
If you add this line back in at the end of after_success will we get codecov back? I'm trying to think about how it would all play out in this scenario. Is it possible to still have codecov with this approach?
There was a problem hiding this comment.
We don't use codecov for Drupal modules do we?
There was a problem hiding this comment.
You can have codecov, I disabled xdebug to get the speed increase and because we didn't seem to ever use codecov for Drupal modules. It can be re-enabled if you desire.
|
no need thanks to #805 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis is broken.
This PR includes:
What does this Pull Request do?
Breaks out the tests into three different categories.
Also includes/tests two other travis fixes.
What's new?
Automated testing is now separating out kernel, functional, and functional javascript.
How should this be tested?
Does Travis pass?
Additional Notes:
Interested parties
Tag @whikloj @dannylamb @Islandora/7-x-1-x-committers