Refactoring multi-file media to create files like we do for other der…

[dannylamb]

…ivatives

Related issue: Islandora/documentation#1731

• Stumbled onto this when testing manually implementing postsave #815

What does this Pull Request do?

Refactors to use the same method of creating files for "regular" derivatives when generating "multi-file media" derivatives.

What's new?

Not much. Just made another function in the service, copy/pasted from other bits, and call that function from controller.

How should this be tested?

• Make a new media type and give it
  • A source field
  • Another file field to hold the derivative (I called mine field_derivative_file) and made sure it could accept xml files
  • The media_of field
• Make a new 'Generate a derivative file for Media Attachment' action. I configured mine to run FITS on the source field like so:
  • Queue Name -> islandora-connector-fits
  • Destination Field File Name -> field_derivative_file
  • Mimetype -> application/xml
  • File Path -> [date:custom:Y]-[date:custom:m]/[media:mid]-fits.xml
• Make a context to pull it all together
  • Condition -> Check for the new media type with the entity_bundle condition
  • Reaction -> Derive File for Existing Media with the new action you just made
• Make a repository item, give it a new media of the type you just created
• The field_derivative_file should be populated with FITS XML

Interested parties

@ajstanley @Islandora/8-x-committers

[ajstanley]

All looks good.

[ajstanley]

Clicked the right button this time.

[dannylamb]

Just pushed some coding standards fixes. Hopefully I can appease Travis.

[elizoller]

@ajstanley can we get a merge? :D