Purge Migrate Tools (Issue 1994) #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned in Islandora/documentation#1994 (reference) , dropping migrate_toolsis not an issue for the playbook. Drupal 9 requires Drush 10+ so this should be a safe assumption. |
seth-shaw-unlv
changed the title
rosiel
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#1994
What does this Pull Request do?
Tells composer to use Migrate Tools 5.0 explicitly and conflict with Drush 10.4.New strategy: purge Migrate Tools altogether.
How should this be tested?
Github workflows should all return green, even the D8 ones.
Additional Notes:
Solution still under discussion. This puts the onus on deployment methods (ansible or isle) to either install migrate tools themselves to use Drush < 10.4 OR ensure that they are using Drush 10.4+.
Interested parties
@Islandora/8-x-committers