Delete content node along with its media and file

[shriram10567]

GitHub Issue: Deleting content node does not delete media/files associated with node

What does this Pull Request do?

This PR adds a checkbox for deleting media in the delete form of islandora objects and lists all the media associated with the object in the form of list

What's new?

• Does this change add any new dependencies? no
• Does this change require any other modifications to be made to the repository
  (i.e. Regeneration activity, etc.)? no
• Could this change impact execution of existing code? no

How should this be tested?

Create some content of the Islandora repository item type and add media to that content using media of field. click the content you created from the content page. In the available tabs for the content, click 'Delete' to see the changes.

the feature can be turned on and off with a checkbox in islandora settings page.

Documentation Status

• Does this change existing behaviour that's currently documented? no
• Does this change require new pages or sections of documentation? probably, yes
• Who does this need to be documented for?
• Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

[jordandukart]

Thanks for the contribution!

Just a note, rendering markup directly within Drupal is normally frowned upon. That is if anything else later on wanted to modify what was here the markup is already generated and you'd have to resort to hacking on strings.

Alternatively if you utilize the #theme key to call item_list you can achieve the same thing while still allowing the theme layer/other modules et al to hook in. More information can be found in the docs as well as an example can be found here.

[alxp]

Hi @shriram1056 ,

In the committers' call today it was brought up that you will need to explicitly delete files along with media if there are zero other references to the file. Drupal will only automatically delete it if it is set to temporary, but this is not the case after it's been created and associated with another entity.

This should be a straightforward addition.

[adam-vessey]

Given this is specifically targeting node, and furthermore, the EntityForm of it, should this instead be more targetedly adjusting the definition of node content entities, such as substituting our own delete and delete-multiple-confirm forms?

In any case, I almost feel like this behaviour probably should be behind a feature toggle, or in another (sub)module, as something like the entity_reference_integrity module with its entity_reference_integrity_enforce submodule should prevent this functionality from working.

[rosiel]

in 5c24c19 a toggle was added.

[jordandukart]

Some more comments after doing a bit of a in-depth dive. If you want some clarification in a more real-time fashion feel free to ping me in the Islandora Slack.

[jordandukart]

Will let this sit for another 24 hours in case someone else wants to jump in but if nothing comes up will press the button.