Fix errors when OCR field not set. #916
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: n/a
What does this Pull Request do?
Fixes Drupal Error Log messages:
What's new?
Do a check that
$ocrfield
isn't null before asking for its->definition
.(i.e. Regeneration activity, etc.)? no
How should this be tested?
Make some content that can show up in an IIIF viewer using a manifest. Don't set up OCR (I didn't know you could set up OCR!) This also works if you go to the IIIF Manifest view, and use the preview function. Render the view (or click Preview) and you get errors in the logs like the one above.
With this PR: no errors.
Documentation Status
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers