-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #946: IIIF Manifest can Retrieve hOCR from a sibling media via Media Use tag #949
Conversation
Views already lets you do this by adding a relationship to Content (via field_media_of) then creating another relationship to a media (via field_media_of) which you can then filter on to have a specific taxonomy term. Then you can expose the field containing the text (likely field_media_file or something) using the previous "Structured OCR Data file field" mechanism. The reason I'm less hyped about this is that it introduces a dependency on the so-called islandora object model, making it unuseable by anyone who isn't linking parent nodes with child media in our method. Before this PR, the code was virtually drupal-ready, meaning we can expose some of our awesomest modules - Openseadragon and Mirador - to other drupal sites - gaining visibility, interest, usage, and potentially assistance on them. |
It would be nice for islandora to provide views plugins that got such things as:
(and implement them separately from the IIIF manifest view so they can be used in all views!) |
@rosiel is a certified Views genius. This change simplifies the PR quite a lot and keeps Islandora IIIF pretty generic and not tied to Islandora. Many thank. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as advertised. We just need to remove the unused IslandoraUtils and this will be good to go. 👍
GitHub Issue: (IIIF manifests should get hOCR from related media with a given tag #
Related PR: #945
What does this Pull Request do?
Allows IIIF Manifest to retrieve hOCR from a sibling media based on its media use ta or any other Views relationship
What's new?
Currently hOCR can be retrieved from a field on the same media as the canvas image. This PR removes the assumption that both fields come from the same media.
How should this be tested??
From a new instance of the starter site, e.g. 'make starter_dev' in ISLE-DC:
config-import.zip
3.1. Unzip the file into your codebase folder so it is accessible inside ISLE-DC, e.g., to codebase/config. The files will be in a folder called 'config-import'./
3.2. Inside Docker's Drupal image, run the command:
drush config:import --partial --source=/var/www/drupal/config/config-import
We should now be able to test hOCR generateion:
docker compose logs -f hypercube
Next test the IIIF Manifest:
The part of this PR that is new is the Views Plugin setting. The rest is already in Islandora.
The exported views config linked above is a good starting point for a starter site example.
Documentation Status
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers