Issue #964: Allow relative paths in IIIF manifests. #965
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: (link)
What does this Pull Request do?
Adds a configuration option for IIIF manifests to use relative paths for image URLs.
What's new?
Adds a config option to make IIIF manifests use local file paths.
(i.e. Regeneration activity, etc.)? No
How should this be tested?
On an Islandora site set up with Islandora IIIF and paged content, go to a piece of paged content, and's manifest URL, usually node/[node:nid]/book-manifest or .../manifest.
Note the image URLs under canvases > images > resources include URL encoded strings representing the full URL of the image, including the Drupal site host.
Go to the Admin settings page for Islandora IIIF, /admin/config/islandora/iiif
Check the 'Use relative paths' option and save the settings.
Reload the same manifest and inspect the @id elements under canvases > resources and note they don't include the full (encoded) url of the Drupal site but only the relative path.
Documentation Status
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
If you want to test this fully including a Cantaloupe stack I can give an example site config and Cantaloupe properties file.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers